[clang] [lld] [lldb] [llvm] [Option] Replace the OptionTables object with a function. NFC (PR #224805)

[Alexis Engelke via cfe-commits]

================
@@ -159,7 +159,6 @@ class LLVM_ABI OptTable {
   struct Tables {
     const StringTable &StrTable;
----------------
aengelke wrote:

Unrelated: shouldn't tthis be `StringTable StrTable`? The reference unnecessarily forces the StringTable = StringRef into memory, creating an avoidable indirection..

https://github.com/llvm/llvm-project/pull/224805