[clang-tools-extra] [clang-tidy] Speed up misc-static-initialization-cycle (PR #224243)
Zeyi Xu via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 17 02:15:31 PDT 2026
https://github.com/zeyi2 created https://github.com/llvm/llvm-project/pull/224243
None
>From cfd48c8a97268ae995938687fa565adf983655e4 Mon Sep 17 00:00:00 2001
From: Zeyi Xu <mitchell.xu2 at gmail.com>
Date: Thu, 17 Sep 2026 17:14:50 +0800
Subject: [PATCH] [clang-tidy] Speed up misc-static-initialization-cycle
---
.../clang-tidy/misc/StaticInitializationCycleCheck.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/misc/StaticInitializationCycleCheck.cpp b/clang-tools-extra/clang-tidy/misc/StaticInitializationCycleCheck.cpp
index 7b1e86b7804fa..aabb7bb71ac4c 100644
--- a/clang-tools-extra/clang-tidy/misc/StaticInitializationCycleCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/StaticInitializationCycleCheck.cpp
@@ -199,8 +199,8 @@ class VarUseCollector : public DynamicRecursiveASTVisitor {
bool VisitDeclRefExpr(DeclRefExpr *DRE) override {
if (const auto *VarD = dyn_cast<VarDecl>(DRE->getDecl());
- VarD && (!shouldIgnoreRef(DRE, Node->getDecl()) &&
- (VarD->hasGlobalStorage() || VarD->isStaticLocal())))
+ VarD && VarD->hasGlobalStorage() &&
+ !shouldIgnoreRef(DRE, Node->getDecl()))
Node->Uses.emplace_back(DRE, G.addNode(VarD->getCanonicalDecl()));
return true;
}
@@ -240,7 +240,8 @@ class VarUseGraphBuilder : public DynamicRecursiveASTVisitor {
}
bool VisitFunctionDecl(FunctionDecl *FD) override {
- if (FD->isGlobal() || FD->isStatic()) {
+ if ((FD->isGlobal() || FD->isStatic()) &&
+ FD->doesThisDeclarationHaveABody()) {
if (Stmt *Body = FD->getBody()) {
VarUseNode *N = G.addNode(FD);
VarUseCollector Collector(N, G);
More information about the cfe-commits
mailing list