[clang] [analyzer] Confidently inline final methods (PR #224070)

[Benedek Kaibas via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/224070 at github.com>


benedekaibas wrote:

I had the same implementation for this issue, but one thing I got stuck on is what would happen if a final derived class that inherits a non-final `virtual` method? I could not come up with a fix for that. That might be an edge case worth confirming if the current implementation misses it. The code I have locally does not work for that scenario. 

I got the idea for testing this scenario while I was reviewing the function specifier: https://en.cppreference.com/cpp/language/virtual#In_detail:~:text=struct%20D%20%3A%20virtual%20B%20%7B%7D%3B

https://github.com/llvm/llvm-project/pull/224070