[clang] [CIR] Split side_effect into memory effects, nounwind, and willreturn (PR #223890)

[Erich Keane via cfe-commits]

================
@@ -1986,39 +1986,74 @@ def CIR_BlockAddrDiffAttr
 }
 
 //===----------------------------------------------------------------------===//
-// Side Effect
+// Memory Effects
 //===----------------------------------------------------------------------===//
 
-def CIR_SideEffect : CIR_I32Enum<
-    "SideEffect", "allowed side effects of a function", [
-      I32EnumCase<"All", 0, "all">,
-      I32EnumCase<"Pure", 1, "pure">,
-      I32EnumCase<"Const", 2, "const">
+def CIR_ModRefInfo : CIR_I32Enum<
+    "ModRefInfo", "how a function accesses one class of memory", [
----------------
erichkeane wrote:

Which class? 

https://github.com/llvm/llvm-project/pull/223890