[clang] [CIR][NFC] Cleanup unhandled NYI in atomic libcall codegen (PR #223732)
Sirui Mu via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 15 08:46:30 PDT 2026
================
@@ -1262,50 +1262,28 @@ static RValue emitLibCallForAtomicExpr(CIRGenFunction &cgf, AtomicExpr *e,
case AtomicExpr::AO__atomic_store:
case AtomicExpr::AO__atomic_store_n:
case AtomicExpr::AO__c11_atomic_store:
+ case AtomicExpr::AO__hip_atomic_store:
----------------
Lancern wrote:
Yeah I'm planning to cover OpenCL and HIP support in later patches, but I was assuming removing those variants from NYI could be fine for now since your previous patch (for atomic exchange) includes OpenCL and HIP variants. Should I keep OpenCL and HIP variants NYI for now? They are NYI in later code anyway.
https://github.com/llvm/llvm-project/pull/223732
More information about the cfe-commits
mailing list