[clang] [clang] Revert "Disable Unique Internal Linkage Names for internal global vars." (PR #219261)

[via cfe-commits]

SharonXSharon wrote:

@yabinc @nickdesaulniers


> 
> > @SharonXSharon can you please fix forward or revert+Reland with a fix? It's probably trivial to add a conditional check and unit test for being aliased.
> 
> thanks for flagging , working on a fix now

after taking a closer look, it seems a simple conditional check won't work, because AsmLabelAttr is attached to the target declaration, while AliasAttr is attached to the separate alias declaration. When isUniqueInternalLinkageDecl() processes the target, that target has no AliasAttr to check. The alias may also be parsed after CodeGen has already
cached or emitted the target’s uniqued name.

Let me know your thoughts, meanwhile, I will go ahead revert the patch for now, and reland  with the proper fix of AsmLabelAttr

https://github.com/llvm/llvm-project/pull/219261