[clang] [Clang] Avoid unnecessary overload resolution when building RecoveryExpr (PR #222296)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 9 07:53:44 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/include/clang/Sema/Overload.h clang/lib/Sema/SemaOverload.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index fb7f1c483..5d008cb2f 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -14796,10 +14796,9 @@ BuildRecoveryCallExpr(Sema &SemaRef, Scope *S, Expr *Fn,
LookupResult R(SemaRef, ULE->getName(), ULE->getNameLoc(),
Sema::LookupOrdinaryName);
CXXRecordDecl *FoundInClass = nullptr;
- if (DiagnoseTwoPhaseLookup(SemaRef, Fn->getExprLoc(), SS, R,
- OverloadCandidateSet::CSK_Normal,
- ResolvedCandidateSet, ExplicitTemplateArgs,
- Args, &FoundInClass)) {
+ if (DiagnoseTwoPhaseLookup(
+ SemaRef, Fn->getExprLoc(), SS, R, OverloadCandidateSet::CSK_Normal,
+ ResolvedCandidateSet, ExplicitTemplateArgs, Args, &FoundInClass)) {
// OK, diagnosed a two-phase lookup issue.
} else if (ResolvedCandidateSet.empty()) {
// Try to recover from an empty lookup with typo correction.
``````````
</details>
https://github.com/llvm/llvm-project/pull/222296
More information about the cfe-commits
mailing list