[clang] [Clang] Avoid unnecessary overload resolution when building RecoveryExpr (PR #222296)

[Erich Keane via cfe-commits]

================
@@ -14634,8 +14647,13 @@ static bool DiagnoseTwoPhaseLookup(
       R.suppressDiagnostics();
 
       OverloadCandidateSet Candidates(FnLoc, CSK);
-      SemaRef.AddOverloadedCallCandidates(R, ExplicitTemplateArgs, Args,
-                                          Candidates);
+      for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
+        if (InvalidCandidates.contains(I->getAsFunction()))
----------------
erichkeane wrote:

Doing this with a set lookup seems wrong?  Since you're looping through it here already, why not do the filtering HERE in the continues? 

https://github.com/llvm/llvm-project/pull/222296