[clang] e85a629 - [NFCI][CIR] Add in 2 missing returns- (#222061)

via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 8 10:47:47 PDT 2026


Author: Erich Keane
Date: 2026-09-08T17:47:41Z
New Revision: e85a62955715c5ff38b685303379313ac81a0bbf

URL: https://github.com/llvm/llvm-project/commit/e85a62955715c5ff38b685303379313ac81a0bbf
DIFF: https://github.com/llvm/llvm-project/commit/e85a62955715c5ff38b685303379313ac81a0bbf.diff

LOG: [NFCI][CIR] Add in 2 missing returns- (#222061)

I discovered these two were missing thanks to a warning diagnostic on a
downstream. It isn't clear why this doesn't cause problems anywhere (we
must just not really use these?), but fix it anyway.

Added: 
    

Modified: 
    clang/include/clang/CIR/Interfaces/CIROpInterfaces.td

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/CIR/Interfaces/CIROpInterfaces.td b/clang/include/clang/CIR/Interfaces/CIROpInterfaces.td
index 08f6bdc024866..c39a9c7818da7 100644
--- a/clang/include/clang/CIR/Interfaces/CIROpInterfaces.td
+++ b/clang/include/clang/CIR/Interfaces/CIROpInterfaces.td
@@ -55,13 +55,13 @@ let cppNamespace = "::cir" in {
                       "std::optional<cir::InlineKind>", "getInlineKind", 
                       (ins), [{}], 
                       /*defaultImplementation=*/[{
-                        $_op.getInlineKind();
+                        return $_op.getInlineKind();
                       }]>,
       InterfaceMethod<[{"Get the inline-kind attribute name"}], 
                       "mlir::StringAttr", "getInlineKindAttrName",
                       (ins), [{}],
                       /*defaultImplementation=*/[{
-                        $_op.getInlineKindAttrName();
+                        return $_op.getInlineKindAttrName();
                       }]>,
     ];
   }


        


More information about the cfe-commits mailing list