ayokunle321 wrote: > I only spot checked the tests, so hopefully you've tested all of them, but the implementation itself seems reasonable to me. Yeah I just cross-checked and all are tested. https://github.com/llvm/llvm-project/pull/221859