[clang] [Clang] Fixed Assertion Checking For Destructor On 'annot_cxxscope' Token (PR #221209)

[Oliver Hunt via cfe-commits]

https://github.com/ojhunt requested changes to this pull request.

The code movement portion of this is probably correct, but the actual "fix" element of it is not: it's simply removing a correct assertion.

An assertion firing is almost _never_ a bug, it is just the first point that the invalid state caused by an earlier bug is detected.

I'm not going to look at this again without an explicit statement on the use (or not) of an LLM in this PR. The details of LLVM's LLM policy can be found at https://llvm.org/docs/AIToolPolicy.html

https://github.com/llvm/llvm-project/pull/221209