[clang] [llvm] DAGCombiner: Drop AllowFPOpFusion from visitFADDForFMACombine (PR #221436)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-rel-x86-64` running on `ml-opt-rel-x86-64-b1` while building `clang,llvm` at step 5 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/185/builds/2462

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/mlgo-emitc.sh --jobs=64' (failure)
...
PASS: LLVM :: CodeGen/AMDGPU/fdot2.ll (639 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/GlobalISel/atomicrmw_uinc_wrap.ll (640 of 67438)
PASS: LLVM :: Analysis/CostModel/X86/rem.ll (641 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/llvm.is.fpclass.bf16.ll (642 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/shufflevector.v3p3.v2p3.ll (643 of 67438)
PASS: LLVM :: TableGen/HwModeEncodeDecode.td (644 of 67438)
PASS: LLVM :: CodeGen/AArch64/atomic-ops.ll (645 of 67438)
PASS: LLVM :: CodeGen/RISCV/GlobalISel/atomic-load-store.ll (646 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/amdgpu.private-memory.ll (647 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/machine-scheduler-sink-trivial-remats-debug.mir (648 of 67438)
FAIL: LLVM :: CodeGen/ARM/fp16-instructions.ll (649 of 67438)
******************** TEST 'LLVM :: CodeGen/ARM/fp16-instructions.ll' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -float-abi=soft     | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -float-abi=soft
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 3
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumb-none-eabi -float-abi=soft   | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumb-none-eabi -float-abi=soft
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 4
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 5
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv8.1m.main-none-eabi -float-abi=soft -mattr=+mve | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumbv8.1m.main-none-eabi -float-abi=soft -mattr=+mve
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 8
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+vfp3        | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -mattr=+vfp3
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# RUN: at line 9
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+vfp4        | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-A32
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -mattr=+vfp4
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-A32
# RUN: at line 10
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64    | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# RUN: at line 12
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv7-none-eabi -mattr=+vfp3        | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumbv7-none-eabi -mattr=+vfp3
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# RUN: at line 13
Step 8 (Run tests) failure: Run tests (failure)
...
PASS: LLVM :: CodeGen/AMDGPU/fdot2.ll (639 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/GlobalISel/atomicrmw_uinc_wrap.ll (640 of 67438)
PASS: LLVM :: Analysis/CostModel/X86/rem.ll (641 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/llvm.is.fpclass.bf16.ll (642 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/shufflevector.v3p3.v2p3.ll (643 of 67438)
PASS: LLVM :: TableGen/HwModeEncodeDecode.td (644 of 67438)
PASS: LLVM :: CodeGen/AArch64/atomic-ops.ll (645 of 67438)
PASS: LLVM :: CodeGen/RISCV/GlobalISel/atomic-load-store.ll (646 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/amdgpu.private-memory.ll (647 of 67438)
PASS: LLVM :: CodeGen/AMDGPU/machine-scheduler-sink-trivial-remats-debug.mir (648 of 67438)
FAIL: LLVM :: CodeGen/ARM/fp16-instructions.ll (649 of 67438)
******************** TEST 'LLVM :: CodeGen/ARM/fp16-instructions.ll' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -float-abi=soft     | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -float-abi=soft
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 3
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumb-none-eabi -float-abi=soft   | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumb-none-eabi -float-abi=soft
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 4
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumbv8.1m.main-none-eabi -mattr=+mve
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 5
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv8.1m.main-none-eabi -float-abi=soft -mattr=+mve | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumbv8.1m.main-none-eabi -float-abi=soft -mattr=+mve
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFT
# RUN: at line 8
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+vfp3        | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -mattr=+vfp3
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# RUN: at line 9
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+vfp4        | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-A32
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -mattr=+vfp4
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FP16,CHECK-SOFTFP-FP16-A32
# RUN: at line 10
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64    | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=arm-none-eabi -mattr=+fullfp16,+fp64
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-FULLFP16
# RUN: at line 12
/b/build/llvm-project/build-mlgo/bin/llc < /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll -mtriple=thumbv7-none-eabi -mattr=+vfp3        | /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# executed command: /b/build/llvm-project/build-mlgo/bin/llc -mtriple=thumbv7-none-eabi -mattr=+vfp3
# executed command: /b/build/llvm-project/build-mlgo/bin/FileCheck /b/build/llvm-project/llvm/test/CodeGen/ARM/fp16-instructions.ll --check-prefixes=CHECK,CHECK-SOFTFP-VFP3
# RUN: at line 13

```

</details>

https://github.com/llvm/llvm-project/pull/221436