[clang] [clang][bytecode] Use a regular static function in `Pointer::toRValue()` (PR #219772)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 91160 tests passed
* 1847 tests skipped
* 3 tests failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.AST/ByteCode/builtins.c</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -fexperimental-new-constant-interpreter /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/builtins.c -verify=expected,both
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -fexperimental-new-constant-interpreter /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/builtins.c -verify=expected,both
# .---command stderr------------
# | error: diagnostics with 'error' severity seen but not expected: 
# |   Line 30: initializer element is not a compile-time constant
# | 1 error generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.AST/ByteCode/c.c</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -triple x86_64-linux -verify=expected,all                   -std=c11 -Wcast-qual           /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/c.c -fexperimental-new-constant-interpreter
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -triple x86_64-linux -verify=expected,all -std=c11 -Wcast-qual /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/AST/ByteCode/c.c -fexperimental-new-constant-interpreter
# .---command stderr------------
# | error: diagnostics with 'error' severity seen but not expected: 
# |   Line 346: initializer element is not a compile-time constant
# | 1 error generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>Clang.SemaCXX/gnu-asm-constexpr.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -fsyntax-only -verify /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp -std=c++26 -triple x86_64-gnu-linux
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -fsyntax-only -verify /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp -std=c++26 -triple x86_64-gnu-linux
# note: command had no output on stdout or stderr
# RUN: at line 2
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -fsyntax-only -verify /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp -std=c++26 -triple x86_64-gnu-linux -fexperimental-new-constant-interpreter
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/24/include -nostdsysteminc -fsyntax-only -verify /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp -std=c++26 -triple x86_64-gnu-linux -fexperimental-new-constant-interpreter
# .---command stderr------------
# | error: 'expected-error' diagnostics expected but not seen: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 119 (directive at /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp:125): invalid output constraint 'g' in asm
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 120 (directive at /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp:126): invalid input constraint '+g' in asm
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 121 (directive at /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp:127): unknown register name 'foo' in asm
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 102: the expression in this asm operand must be produced by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 103: the expression in this asm operand must be produced by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 104: the expression in this asm operand must be produced by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 119: the expression in this asm operand must be produced by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 120: the expression in this asm operand must be produced by a constant expression
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 121: the expression in this asm operand must be produced by a constant expression
# | error: 'expected-note' diagnostics seen but not expected: 
# |   File /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/SemaCXX/gnu-asm-constexpr.cpp Line 114: in instantiation of function template specialization 'test_dependent1<string_view>' requested here
# | 10 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/219772