[clang] [analyzer] Print comparison literals with the right signedness (PR #219136)

DonĂ¡t Nagy via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 27 01:21:03 PDT 2026


================
@@ -513,10 +513,10 @@ class ConditionBRVisitor final : public BugReporterVisitor {
   bool printValue(const Expr *CondVarExpr, raw_ostream &Out,
                   const ExplodedNode *N, bool TookTrue, bool IsAssuming);
 
-  bool patternMatch(const Expr *Ex, const Expr *ParentEx, raw_ostream &Out,
-                    BugReporterContext &BRC, PathSensitiveBugReport &R,
-                    const ExplodedNode *N, std::optional<bool> &prunable,
-                    bool IsSameFieldName);
+  bool patternMatch(const Expr *Ex, const Expr *ParentEx, const Expr *OtherEx,
+                    raw_ostream &Out, BugReporterContext &BRC,
+                    PathSensitiveBugReport &R, const ExplodedNode *N,
+                    std::optional<bool> &prunable, bool IsSameFieldName);
----------------
NagyDonat wrote:

```suggestion
                    std::optional<bool> &Prunable, bool IsSameFieldName);
```
As you're already touching these lines, why not capitalize this variable?

https://github.com/llvm/llvm-project/pull/219136


More information about the cfe-commits mailing list