[clang] [NFC][analyzer] Tweak constness of CheckerContext methods (PR #218937)

[Arseniy Zaostrovnykh via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/218937 at github.com>


https://github.com/necto approved this pull request.

> Even if the CheckerContext object is immutable, this method can return its "pointer to non-const ExplodedNode" data member by value. (And then "pointer to non-const ExplodedNode" is implicitly convertible to "pointer to const ExplodedNode".)

> We don't lose any opportunity with this change.

Right. const-pointer vs. pointer-to-const tripped me over

https://github.com/llvm/llvm-project/pull/218937