[clang] [clang][bytecode] Optimize canClassify/classify (PR #218397)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 24 05:56:05 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
<details>
<summary>Changes</summary>
Always get the canonical type and handle some more builtin types in canClassify().
---
Full diff: https://github.com/llvm/llvm-project/pull/218397.diff
2 Files Affected:
- (modified) clang/lib/AST/ByteCode/Context.cpp (+3-5)
- (modified) clang/lib/AST/ByteCode/Context.h (+2-1)
``````````diff
diff --git a/clang/lib/AST/ByteCode/Context.cpp b/clang/lib/AST/ByteCode/Context.cpp
index 0678b07d0bbf2..96f26a6a7a083 100644
--- a/clang/lib/AST/ByteCode/Context.cpp
+++ b/clang/lib/AST/ByteCode/Context.cpp
@@ -463,8 +463,9 @@ static PrimType integralTypeToPrimTypeU(unsigned BitWidth) {
}
OptPrimType Context::classify(QualType T) const {
+ T = T.getCanonicalType();
- if (const auto *BT = dyn_cast<BuiltinType>(T.getCanonicalType())) {
+ if (const auto *BT = dyn_cast<BuiltinType>(T)) {
auto Kind = BT->getKind();
if (Kind == BuiltinType::Bool)
return PT_Bool;
@@ -528,10 +529,7 @@ OptPrimType Context::classify(QualType T) const {
if (const auto *AT = T->getAs<AtomicType>())
return classify(AT->getValueType());
- if (const auto *DT = dyn_cast<DecltypeType>(T))
- return classify(DT->getUnderlyingType());
-
- if (const auto *OBT = T.getCanonicalType()->getAs<OverflowBehaviorType>())
+ if (const auto *OBT = T->getAs<OverflowBehaviorType>())
return classify(OBT->getUnderlyingType());
if (T->isObjCObjectPointerType() || T->isBlockPointerType())
diff --git a/clang/lib/AST/ByteCode/Context.h b/clang/lib/AST/ByteCode/Context.h
index eaace87ceae9d..586b600614596 100644
--- a/clang/lib/AST/ByteCode/Context.h
+++ b/clang/lib/AST/ByteCode/Context.h
@@ -131,7 +131,8 @@ class Context final {
if (const auto *BT = dyn_cast<BuiltinType>(T)) {
if (BT->isInteger() || BT->isFloatingPoint())
return true;
- if (BT->getKind() == BuiltinType::Bool)
+ if (BT->getKind() == BuiltinType::NullPtr ||
+ BT->getKind() == BuiltinType::BoundMember)
return true;
}
if (T->isPointerOrReferenceType())
``````````
</details>
https://github.com/llvm/llvm-project/pull/218397
More information about the cfe-commits
mailing list