[clang] [analyzer] Model concrete floating-point values (PR #214098)

[Balázs Benics via cfe-commits]

================
@@ -436,8 +436,10 @@ SVal SimpleSValBuilder::evalBinOpNN(ProgramStateRef state,
   if (auto simplifiedRhsAsNonLoc = simplifiedRhs.getAs<NonLoc>())
     rhs = *simplifiedRhsAsNonLoc;
 
-  // Handle trivial case where left-side and right-side are the same.
-  if (lhs == rhs)
+  // Handle trivial case where left-side and right-side are the same. Exclude
+  // floating points: the ConcreteFloat case below folds these correctly
+  // instead.
----------------
steakhal wrote:

I hate when somebody starts a sentence and then I have to find how it continues xD Let's start sentences at the beginning of the line when it soo clearly overflows into the next line.
```suggestion
  // Handle trivial case where left-side and right-side are the same.
  // Exclude floating points: the ConcreteFloat case below folds these
  // correctly instead.
```

https://github.com/llvm/llvm-project/pull/214098