[clang] [analyzer][z3] Fix SMTConstraintManager.h removeDeadBindings (PR #215240)

[Donát Nagy via cfe-commits]

================
@@ -224,10 +228,39 @@ class SMTConstraintManager : public clang::ento::SimpleConstraintManager {
                                      SymbolReaper &SymReaper) override {
     auto CZ = State->get<ConstraintSMT>();
     auto &CZFactory = State->get_context<ConstraintSMT>();
+    llvm::SmallVector<ConstraintEntry> Constraints(CZ.begin(), CZ.end());
----------------
NagyDonat wrote:

> I wanted a vector for random access, so I copied it into a llvm::SmallVector.

Yes, I see that you rely on indexing; that's a fair reason.

https://github.com/llvm/llvm-project/pull/215240