[clang] [analyzer] Fix timing of `PostStmt<CXXDeleteExpr>` (PR #215828)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 56039 tests passed
* 1487 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### Clang
<details>
<summary>Clang.Analysis/cxx-dynamic-memory-analysis-order.cpp</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\clang.exe -cc1 -internal-isystem C:\_work\llvm-project\llvm-project\build\lib\clang\24\include -nostdsysteminc -analyze -setup-static-analyzer -std=c++20 -fblocks -verify C:\_work\llvm-project\llvm-project\clang\test\Analysis\cxx-dynamic-memory-analysis-order.cpp    -analyzer-checker=core    -analyzer-checker=debug.AnalysisOrder    -analyzer-config debug.AnalysisOrder:PreStmtCXXNewExpr=true    -analyzer-config debug.AnalysisOrder:PostStmtCXXNewExpr=true    -analyzer-config debug.AnalysisOrder:PreStmtCXXDeleteExpr=true    -analyzer-config debug.AnalysisOrder:PostStmtCXXDeleteExpr=true    -analyzer-config debug.AnalysisOrder:PreCall=true    -analyzer-config debug.AnalysisOrder:PostCall=true    2>&1 | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\clang\test\Analysis\cxx-dynamic-memory-analysis-order.cpp
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\clang.exe' -cc1 -internal-isystem 'C:\_work\llvm-project\llvm-project\build\lib\clang\24\include' -nostdsysteminc -analyze -setup-static-analyzer -std=c++20 -fblocks -verify 'C:\_work\llvm-project\llvm-project\clang\test\Analysis\cxx-dynamic-memory-analysis-order.cpp' -analyzer-checker=core -analyzer-checker=debug.AnalysisOrder -analyzer-config debug.AnalysisOrder:PreStmtCXXNewExpr=true -analyzer-config debug.AnalysisOrder:PostStmtCXXNewExpr=true -analyzer-config debug.AnalysisOrder:PreStmtCXXDeleteExpr=true -analyzer-config debug.AnalysisOrder:PostStmtCXXDeleteExpr=true -analyzer-config debug.AnalysisOrder:PreCall=true -analyzer-config debug.AnalysisOrder:PostCall=true
# note: command had no output on stdout or stderr
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\clang\test\Analysis\cxx-dynamic-memory-analysis-order.cpp'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\clang\test\Analysis\cxx-dynamic-memory-analysis-order.cpp:41:17: error: CHECK-NEXT: is not on the line after the previous match
# |  // CHECK-NEXT: PostStmt<CXXDeleteExpr>
# |                 ^
# | <stdin>:8:1: note: 'next' match was here
# | PostStmt<CXXDeleteExpr>
# | ^
# | <stdin>:5:23: note: previous match ended here
# | PreStmt<CXXDeleteExpr>
# |                       ^
# | <stdin>:6:1: note: non-matching line after previous match is here
# | PreCall (operator delete) [CXXDeallocatorCall]
# | ^
# | 
# | Input file: <stdin>
# | Check file: C:\_work\llvm-project\llvm-project\clang\test\Analysis\cxx-dynamic-memory-analysis-order.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |            1: PreCall (operator new) [CXXAllocatorCall] 
# |            2: PostCall (operator new) [CXXAllocatorCall] 
# |            3: PreStmt<CXXNewExpr> 
# |            4: PostStmt<CXXNewExpr> 
# |            5: PreStmt<CXXDeleteExpr> 
# | next:41'0                          {   search range start (exclusive)
# |            6: PreCall (operator delete) [CXXDeallocatorCall] 
# |            7: PostCall (operator delete) [CXXDeallocatorCall] 
# |            8: PostStmt<CXXDeleteExpr> 
# | next:41'1     !~~~~~~~~~~~~~~~~~~~~~~   error: match on wrong line
# |            9: PreCall (operator new) [CXXAllocatorCall] 
# |           10: PostCall (operator new) [CXXAllocatorCall] 
# |           11: PreStmt<CXXNewExpr> 
# |           12: PostStmt<CXXNewExpr> 
# |           13: PreCall (operator delete) [SimpleFunctionCall] 
# |            .
# |            .
# |            .
# |           59: PreCall (operator delete[]) [SimpleFunctionCall] 
# |           60: PostCall (operator delete[]) [SimpleFunctionCall] 
# |           61: PreCall (operator new[]) [SimpleFunctionCall] 
# |           62: PostCall (operator new[]) [SimpleFunctionCall] 
# |           63: PreCall (operator delete[]) [SimpleFunctionCall] 
# |           64: PostCall (operator delete[]) [SimpleFunctionCall] 
# | next:41'2                                                       } search range end (exclusive)
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/215828