[clang] [SystemZ][Clang]Use the function name from the source for name PPA1 (PR #209215)

[Oliver Hunt via cfe-commits]

https://github.com/ojhunt requested changes to this pull request.

Ok, my first question is why zos is using a different IR symbol convention than other platforms? is that really necessary? To _me_ this seems like a kind of hacky change to the frontend to handle unnecessarily different behavior in the backend. I'm happy to be corrected, but nothing in the behavior you've described seems to indicate any fundamental reason for the divergence.

The hoisting of `getMangledNameImpl` into the CodeGenModule interface is an unnecessary exposure of an implementation detail to the API, and it's responsible for the bulk of the whitespace change.

Assuming it is necessary to have this override behavior the correct course of action here would be to add an purpose named function on CGM, that internally calls the implementation with the appropriate override flags.

My inclination is that the myriad "WantAsmLabel" parameters should be a property of the MangleContext, not an argument.


https://github.com/llvm/llvm-project/pull/209215