[clang-tools-extra] fix pp-trace crashes with no options (PR #215452)

via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 10 20:40:02 PDT 2026


llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang-tools-extra

Author: biubiuzy

<details>
<summary>Changes</summary>

Currently, executing pp-trace without parameters causes a crash. Now:
```
# pp-trace
error: pp-trace: Not enough positional command line arguments specified!
Must specify at least 1 positional argument: See: pp-trace --help
```

---
Full diff: https://github.com/llvm/llvm-project/pull/215452.diff


1 Files Affected:

- (modified) clang-tools-extra/pp-trace/PPTrace.cpp (+1-1) 


``````````diff
diff --git a/clang-tools-extra/pp-trace/PPTrace.cpp b/clang-tools-extra/pp-trace/PPTrace.cpp
index ba5a06a26830d..7b4ffa419c75b 100644
--- a/clang-tools-extra/pp-trace/PPTrace.cpp
+++ b/clang-tools-extra/pp-trace/PPTrace.cpp
@@ -129,7 +129,7 @@ int main(int argc, const char **argv) {
   using namespace clang::pp_trace;
   InitLLVM X(argc, argv);
   auto OptionsParser = clang::tooling::CommonOptionsParser::create(
-      argc, argv, Cat, llvm::cl::ZeroOrMore);
+      argc, argv, Cat, llvm::cl::OneOrMore);
   if (!OptionsParser)
     error(toString(OptionsParser.takeError()));
   // Parse the IgnoreCallbacks list into strings.

``````````

</details>


https://github.com/llvm/llvm-project/pull/215452


More information about the cfe-commits mailing list