[clang] [CIR][CodeGen] Emit cir.fmuladd for FP-contracted mul+add/sub (PR #215382)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 10 13:12:24 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions c,cpp -- clang/test/CIR/CodeGen/fp-contract-on-pragma.cpp clang/test/CIR/CodeGen/fp-contract-pragma.cpp clang/test/CIR/CodeGen/fp-contract.c clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
index 7e2c057c1..f3e8e646c 100644
--- a/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenExprScalar.cpp
@@ -1977,8 +1977,8 @@ static mlir::Value buildFMulAdd(cir::FMulOp mulOp, mlir::Value addend,
// Checks that (a) the operation is fusable, and (b) -ffp-contract=on.
// Does NOT check the type of the operation - it's assumed that this function
// will be called from contexts where it's known that the type is contractable.
-static mlir::Value tryEmitFMulAdd(const BinOpInfo &op,
- CIRGenBuilderTy &builder, bool isSub = false) {
+static mlir::Value tryEmitFMulAdd(const BinOpInfo &op, CIRGenBuilderTy &builder,
+ bool isSub = false) {
assert((op.opcode == BO_Add || op.opcode == BO_AddAssign ||
op.opcode == BO_Sub || op.opcode == BO_SubAssign) &&
"Only fadd/fsub can be the root of an fmuladd.");
``````````
</details>
https://github.com/llvm/llvm-project/pull/215382
More information about the cfe-commits
mailing list