[clang] [Lifetime Safety] Highlight lifetimebound calls in alias chain diagnostics (PR #206337)

[via cfe-commits]

================
@@ -680,16 +680,35 @@ class LifetimeSafetySemaHelperImpl : public LifetimeSafetySemaHelper {
       return;
 
     const Expr *LastExpr = OriginExprChain.back();
-    std::string IssueStr = getDiagSubjectDescription(LastExpr);
+    const Expr *VisibleLastExpr = LastExpr;
+    std::string IssueStr = getDiagSubjectDescription(VisibleLastExpr);
 
     for (const Expr *CurrExpr : reverse(OriginExprChain.drop_back())) {
-      if (!shouldShowInAliasChain(CurrExpr, LastExpr))
-        continue;
-      S.Diag(CurrExpr->getBeginLoc(),
-             diag::note_lifetime_safety_aliases_storage)
-          << CurrExpr->getSourceRange() << getDiagSubjectDescription(CurrExpr)
-          << IssueStr;
+      const Expr *PrevExpr = LastExpr;
       LastExpr = CurrExpr;
----------------
NeKon69 wrote:

I think this variable is not needed.

https://github.com/llvm/llvm-project/pull/206337