[clang] [clang][Lex] Fix conflicting RemoveTopOfLexerStack docs (PR #214679)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Aug 7 04:24:58 PDT 2026
https://github.com/richardmilles updated https://github.com/llvm/llvm-project/pull/214679
>From 3ea59eac6858789efe7656d15aff9e73d46b2df5 Mon Sep 17 00:00:00 2001
From: richardmilles <darkenhalneke at gmail.com>
Date: Fri, 7 Aug 2026 10:17:06 +0200
Subject: [PATCH 1/2] [clang][Lex] Fix conflicting RemoveTopOfLexerStack docs
Fixes #53214
---
clang/include/clang/Lex/Preprocessor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang/include/clang/Lex/Preprocessor.h b/clang/include/clang/Lex/Preprocessor.h
index e752010dd2062..6b91a622961c4 100644
--- a/clang/include/clang/Lex/Preprocessor.h
+++ b/clang/include/clang/Lex/Preprocessor.h
@@ -1747,7 +1747,7 @@ class Preprocessor {
/// Pop the current lexer/macro exp off the top of the lexer stack.
///
/// This should only be used in situations where the current state of the
- /// top-of-stack lexer is known.
+ /// top-of-stack lexer is unknown.
void RemoveTopOfLexerStack();
/// From the point that this method is called, and until
>From 4488aeb1c32574605927f0bfc3d027b49c65978a Mon Sep 17 00:00:00 2001
From: richardmilles <darkenhalneke at gmail.com>
Date: Fri, 7 Aug 2026 13:24:07 +0200
Subject: [PATCH 2/2] [clang][Lex] Drop duplicate RemoveTopOfLexerStack doc
comment
Keep the corrected comment in the header only.
---
clang/lib/Lex/PPLexerChange.cpp | 3 ---
1 file changed, 3 deletions(-)
diff --git a/clang/lib/Lex/PPLexerChange.cpp b/clang/lib/Lex/PPLexerChange.cpp
index b44bf2cd3c253..eca5febf0efee 100644
--- a/clang/lib/Lex/PPLexerChange.cpp
+++ b/clang/lib/Lex/PPLexerChange.cpp
@@ -615,9 +615,6 @@ bool Preprocessor::HandleEndOfTokenLexer(Token &Result) {
return HandleEndOfFile(Result, true);
}
-/// RemoveTopOfLexerStack - Pop the current lexer/macro exp off the top of the
-/// lexer stack. This should only be used in situations where the current
-/// state of the top-of-stack lexer is unknown.
void Preprocessor::RemoveTopOfLexerStack() {
assert(!IncludeMacroStack.empty() && "Ran out of stack entries to load");
More information about the cfe-commits
mailing list