[clang] [HLSL] Consistently quote resource attribute args (PR #214106)
Justin Bogner via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 5 17:48:00 PDT 2026
================
@@ -2,24 +2,24 @@
typedef vector<float, 4> float4;
-// CHECK: -TypeAliasDecl 0x{{[0-9a-f]+}} <line:[[# @LINE + 4]]:1, col:83>
+// CHECK: -TypeAliasDecl 0x{{[0-9a-f]+}} <line:[[# @LINE + 4]]:1, col:85>
----------------
bogner wrote:
This changes the end of the source range - the range is `<line:9:1, col:85>`, so on line 9, from column 1 to 85. The source location range here is the entire using declaration.
That said, 83/85 is a little bit odd, since the semicolon is on column 105. I guess this range looks something like:
```
using ResourceIntAliasT = __hlsl_resource_t [[hlsl::resource_class("UAV")]] [[hlsl::contained_type(int)]];
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
```
I'll follow up on this separately.
https://github.com/llvm/llvm-project/pull/214106
More information about the cfe-commits
mailing list