[clang] [clang][ASTImporter] Link FunctionDecl into its DeclContext before importing its body (PR #214009)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 90665 tests passed
* 1754 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### lldb-shell
<details>
<summary>lldb-shell.Expr/TestLambdaExprImport.test</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 5
split-file /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Expr/TestLambdaExprImport.test /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp
# executed command: split-file /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Expr/TestLambdaExprImport.test /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp
# note: command had no output on stdout or stderr
# RUN: at line 6
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang --driver-mode=g++ --target=specify-a-target-or-use-a-_host-substitution --target=x86_64-unknown-linux-gnu -pthread -fmodules-cache-path=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-shell -g -gdwarf /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp/main.cpp -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp.out
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang --driver-mode=g++ --target=specify-a-target-or-use-a-_host-substitution --target=x86_64-unknown-linux-gnu -pthread -fmodules-cache-path=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-shell -g -gdwarf /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp/main.cpp -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp.out
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-fmodules-cache-path=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-shell' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 7
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/lldb --no-lldbinit -S /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet -o "settings set interpreter.stop-command-source-on-error false"        -x -b -s /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp/commands.input /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp.out 2>&1        | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Expr/TestLambdaExprImport.test
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/lldb --no-lldbinit -S /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet -o 'settings set interpreter.stop-command-source-on-error false' -x -b -s /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp/commands.input /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Expr/Output/TestLambdaExprImport.test.tmp.out
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Expr/TestLambdaExprImport.test
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Expr/TestLambdaExprImport.test:25:14: error: CHECK-NOT: excluded string found in input
# | # CHECK-NOT: FunctionDecl
# |              ^
# | <stdin>:24:3: note: found here
# | `-FunctionDecl 0x28ca05d0 <<user expression 0>:1:1, col:35> col:6 method 'void (int)' external-linkage
# |   ^~~~~~~~~~~~
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Expr/TestLambdaExprImport.test
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           .
# |           .
# |           .
# |          16:  3 __builtin_debugtrap(); 
# |          17: -> 4 } 
# |          18:  ^ 
# |          19:  5 
# |          20: (lldb) expression --top-level -- void method(int x) { [x=x] { ; }; } 
# |          21: (lldb) target dump typesystem 
# | not:25'0                                 {   search range start (exclusive)
# |          22: State of scratch Clang type system: 
# |          23: TranslationUnitDecl 0x28c9fc68 <<invalid sloc>> <invalid sloc> <undeserialized declarations> 
# |          24: `-FunctionDecl 0x28ca05d0 <<user expression 0>:1:1, col:35> col:6 method 'void (int)' external-linkage 
# | not:25'1       !~~~~~~~~~~~                                                                                           error: no match expected
# |          25:  `-ParmVarDecl 0x28ca0560 <col:13, col:17> col:17 used x 'int' 
# | not:25'2                                                                    } search range end (exclusive)
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/214009