https://github.com/ojhunt commented: I think this looks reasonable (sans my code structure complaints which are not strong), but I'm not convinced this is an area where me approving the change is appropriate. https://github.com/llvm/llvm-project/pull/212368