[clang-tools-extra] [clang-tidy][NFC] Apply const-correctness for auto 3/N (PR #213841)
via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 3 22:28:16 PDT 2026
llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Baranov Victor (vbvictor)
<details>
<summary>Changes</summary>
---
Patch is 90.03 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/213841.diff
57 Files Affected:
- (modified) clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp (+2-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp (+3-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/AssignmentInSelectionStatementCheck.cpp (+6-5)
- (modified) clang-tools-extra/clang-tidy/bugprone/BitwisePointerCastCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp (+3-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/ComparePointerToMemberVirtualFunctionCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/CopyConstructorInitCheck.cpp (+4-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp (+14-14)
- (modified) clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp (+13-12)
- (modified) clang-tools-extra/clang-tidy/bugprone/IncDecInConditionsCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp (+3-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/IncorrectRoundingsCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/InvalidEnumDefaultInitializationCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/LambdaFunctionNameCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp (+11-11)
- (modified) clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/MissingEndComparisonCheck.cpp (+3-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/MoveForwardingReferenceCheck.cpp (+6-5)
- (modified) clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp (+11-8)
- (modified) clang-tools-extra/clang-tidy/bugprone/MultipleStatementMacroCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/NondeterministicPointerIterationOrderCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp (+35-32)
- (modified) clang-tools-extra/clang-tidy/bugprone/OptionalValueConversionCheck.cpp (+4-4)
- (modified) clang-tools-extra/clang-tidy/bugprone/ParentVirtualCallCheck.cpp (+6-5)
- (modified) clang-tools-extra/clang-tidy/bugprone/RandomGeneratorSeedCheck.cpp (+4-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/RawMemoryCallOnNonTrivialTypeCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp (+2-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/ReservedIdentifierCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp (+4-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/SizeofContainerCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/SmartPtrArrayMismatchCheck.cpp (+8-8)
- (modified) clang-tools-extra/clang-tidy/bugprone/StdNamespaceModificationCheck.cpp (+5-5)
- (modified) clang-tools-extra/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp (+37-36)
- (modified) clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/SuspiciousMemsetUsageCheck.cpp (+4-4)
- (modified) clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/SuspiciousReallocUsageCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/SuspiciousStringviewDataUsageCheck.cpp (+3-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/TaggedUnionMemberCountCheck.cpp (+7-5)
- (modified) clang-tools-extra/clang-tidy/bugprone/TerminatingContinueCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/UnhandledExceptionAtNewCheck.cpp (+4-3)
- (modified) clang-tools-extra/clang-tidy/bugprone/UniquePtrArrayMismatchCheck.cpp (+1-1)
- (modified) clang-tools-extra/clang-tidy/bugprone/UnsafeFunctionsCheck.cpp (+4-4)
- (modified) clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp (+3-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp (+2-2)
- (modified) clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp (+9-8)
- (modified) clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp (+3-3)
``````````diff
diff --git a/clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp
index 8b78b5a50f0c8..2f260c36155ff 100644
--- a/clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp
@@ -314,7 +314,8 @@ void ArgumentCommentCheck::checkCallArgs(ASTContext *Ctx,
if ((NumArgs == 0) || (IgnoreSingleArgument && NumArgs == 1))
return;
- auto MakeFileCharRange = [Ctx](SourceLocation Begin, SourceLocation End) {
+ const auto MakeFileCharRange = [Ctx](SourceLocation Begin,
+ SourceLocation End) {
return Lexer::makeFileCharRange(CharSourceRange::getCharRange(Begin, End),
Ctx->getSourceManager(),
Ctx->getLangOpts());
diff --git a/clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
index 574ccfc255a53..b7c7a3196d787 100644
--- a/clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp
@@ -103,13 +103,13 @@ void AssertSideEffectCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
}
void AssertSideEffectCheck::registerMatchers(MatchFinder *Finder) {
- auto IgnoredFunctionsMatcher =
+ const auto IgnoredFunctionsMatcher =
matchers::matchesAnyListedRegexName(IgnoredFunctions);
- auto DescendantWithSideEffect =
+ const auto DescendantWithSideEffect =
traverse(TK_AsIs, hasDescendant(expr(hasSideEffect(
CheckFunctionCalls, IgnoredFunctionsMatcher))));
- auto ConditionWithSideEffect = hasCondition(DescendantWithSideEffect);
+ const auto ConditionWithSideEffect = hasCondition(DescendantWithSideEffect);
Finder->addMatcher(
stmt(
anyOf(conditionalOperator(ConditionWithSideEffect),
diff --git a/clang-tools-extra/clang-tidy/bugprone/AssignmentInSelectionStatementCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/AssignmentInSelectionStatementCheck.cpp
index 546d66f9c1452..f0ded3d9e4562 100644
--- a/clang-tools-extra/clang-tidy/bugprone/AssignmentInSelectionStatementCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/AssignmentInSelectionStatementCheck.cpp
@@ -52,8 +52,8 @@ AST_MATCHER_P(Expr, conditionValueCanPropagateFrom,
// Ignore implicit casts (including C++ conversion member calls) but not parens.
AST_MATCHER_P(Expr, ignoringImplicitAsWritten,
ast_matchers::internal::Matcher<Expr>, InnerMatcher) {
- auto IgnoreImplicitMemberCallSingleStep = [](Expr *E) {
- if (auto *C = dyn_cast<CXXMemberCallExpr>(E)) {
+ const auto IgnoreImplicitMemberCallSingleStep = [](Expr *E) {
+ if (const auto *C = dyn_cast<CXXMemberCallExpr>(E)) {
Expr *ExprNode = C->getImplicitObjectArgument();
if (ExprNode->getSourceRange() == E->getSourceRange())
return ExprNode;
@@ -84,8 +84,9 @@ void AssignmentInSelectionStatementCheck::registerMatchers(
auto AssignOpFromEmbeddedExpr = expr(ignoringParenImpCasts(
conditionValueCanPropagateFrom(AssignOpMaybeParens)));
- auto CondExprWithAssign = anyOf(AssignOpNoParens, AssignOpFromEmbeddedExpr);
- auto OpCondExprWithAssign =
+ const auto CondExprWithAssign =
+ anyOf(AssignOpNoParens, AssignOpFromEmbeddedExpr);
+ const auto OpCondExprWithAssign =
anyOf(AssignOpMaybeParens, AssignOpFromEmbeddedExpr);
// In these cases "single primary expression" is possible.
@@ -102,7 +103,7 @@ void AssignmentInSelectionStatementCheck::registerMatchers(
hasAnyOperatorName("&&", "||"),
eachOf(hasLHS(OpCondExprWithAssign), hasRHS(OpCondExprWithAssign)));
- auto FoundSelectionStmt =
+ const auto FoundSelectionStmt =
stmt(anyOf(FoundControlStmt, FoundConditionalOperator, FoundLogicalOp))
.bind("parent");
diff --git a/clang-tools-extra/clang-tidy/bugprone/BitwisePointerCastCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/BitwisePointerCastCheck.cpp
index a9e7ae8734677..b8b4948665b0f 100644
--- a/clang-tools-extra/clang-tidy/bugprone/BitwisePointerCastCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/BitwisePointerCastCheck.cpp
@@ -15,7 +15,7 @@ namespace clang::tidy::bugprone {
void BitwisePointerCastCheck::registerMatchers(MatchFinder *Finder) {
if (getLangOpts().CPlusPlus20) {
- auto IsPointerType = refersToType(qualType(isAnyPointer()));
+ const auto IsPointerType = refersToType(qualType(isAnyPointer()));
Finder->addMatcher(callExpr(hasDeclaration(functionDecl(allOf(
hasName("::std::bit_cast"),
hasTemplateArgument(0, IsPointerType),
@@ -24,7 +24,7 @@ void BitwisePointerCastCheck::registerMatchers(MatchFinder *Finder) {
this);
}
- auto IsDoublePointerType =
+ const auto IsDoublePointerType =
hasType(qualType(pointsTo(qualType(isAnyPointer()))));
Finder->addMatcher(callExpr(hasArgument(0, IsDoublePointerType),
hasArgument(1, IsDoublePointerType),
diff --git a/clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
index 588f9bfe076df..ad6b12c1d7d2f 100644
--- a/clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
@@ -402,7 +402,7 @@ void BranchCloneCheck::check(const MatchFinder::MatchResult &Result) {
Branches.back().push_back(S);
}
- auto *End = Branches.end();
+ const auto *End = Branches.end();
auto *BeginCurrent = Branches.begin();
while (BeginCurrent < End) {
if (isFallthroughSwitchBranch(*BeginCurrent)) {
diff --git a/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
index 5adf8f97ee8f0..a78af8aa2fea3 100644
--- a/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/CapturingThisInMemberVariableCheck.cpp
@@ -83,11 +83,11 @@ void CapturingThisInMemberVariableCheck::storeOptions(
}
void CapturingThisInMemberVariableCheck::registerMatchers(MatchFinder *Finder) {
- auto IsStdFunctionField =
+ const auto IsStdFunctionField =
fieldDecl(hasType(cxxRecordDecl(
matchers::matchesAnyListedRegexName(FunctionWrapperTypes))))
.bind("field");
- auto CaptureThis = lambdaCapture(anyOf(
+ const auto CaptureThis = lambdaCapture(anyOf(
// [this]
capturesThis(),
// [self = this]
@@ -102,7 +102,7 @@ void CapturingThisInMemberVariableCheck::registerMatchers(MatchFinder *Finder) {
hasAnyArgument(cxxThisExpr()))
.bind("bind");
- auto IsInitWithLambdaOrBind =
+ const auto IsInitWithLambdaOrBind =
anyOf(IsLambdaCapturingThis, IsBindCapturingThis,
cxxConstructExpr(hasArgument(
0, anyOf(IsLambdaCapturingThis, IsBindCapturingThis))));
diff --git a/clang-tools-extra/clang-tidy/bugprone/ComparePointerToMemberVirtualFunctionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ComparePointerToMemberVirtualFunctionCheck.cpp
index 91290c2850c57..8b1fbe04fb1eb 100644
--- a/clang-tools-extra/clang-tidy/bugprone/ComparePointerToMemberVirtualFunctionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/ComparePointerToMemberVirtualFunctionCheck.cpp
@@ -34,10 +34,10 @@ static constexpr StringRef ErrorMsg =
void ComparePointerToMemberVirtualFunctionCheck::registerMatchers(
MatchFinder *Finder) {
- auto DirectMemberVirtualFunctionPointer = unaryOperator(
+ const auto DirectMemberVirtualFunctionPointer = unaryOperator(
allOf(hasOperatorName("&"),
hasUnaryOperand(declRefExpr(to(cxxMethodDecl(isVirtual()))))));
- auto IndirectMemberPointer =
+ const auto IndirectMemberPointer =
ignoringImpCasts(declRefExpr().bind("indirect_member_pointer"));
Finder->addMatcher(
diff --git a/clang-tools-extra/clang-tidy/bugprone/CopyConstructorInitCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/CopyConstructorInitCheck.cpp
index ccbc86ae74cc6..5809dcfb4bd1c 100644
--- a/clang-tools-extra/clang-tidy/bugprone/CopyConstructorInitCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/CopyConstructorInitCheck.cpp
@@ -87,9 +87,10 @@ void CopyConstructorInitCheck::check(const MatchFinder::MatchResult &Result) {
if (!HasRelevantBaseInit)
return;
- auto Diag = diag(Ctor->getLocation(),
- "calling a base constructor other than the copy constructor")
- << SafeFixIts;
+ const auto Diag =
+ diag(Ctor->getLocation(),
+ "calling a base constructor other than the copy constructor")
+ << SafeFixIts;
if (FixItInitList.empty() || ParamName.empty() || ShouldNotDoFixit)
return;
diff --git a/clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp
index 8c8a9020011b0..13d9750234b0d 100644
--- a/clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/CrtpConstructorAccessibilityCheck.cpp
@@ -129,8 +129,8 @@ void CrtpConstructorAccessibilityCheck::check(
<< HintFriend;
}
- auto WithFriendHintIfNeeded = [&](const DiagnosticBuilder &Diag,
- bool NeedsFriend) {
+ const auto WithFriendHintIfNeeded = [&](const DiagnosticBuilder &Diag,
+ bool NeedsFriend) {
if (NeedsFriend)
Diag << HintFriend;
};
diff --git a/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
index e95af89375dc8..0e0f3b95fffdd 100644
--- a/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp
@@ -278,7 +278,7 @@ struct ConversionSequence {
/// the conversion sequence. This method does **NOT** return Begin and End.
SmallVector<QualType, 4> getInvolvedTypesInSequence() const {
SmallVector<QualType, 4> Ret;
- auto EmplaceIfDifferent = [&Ret](QualType QT) {
+ const auto EmplaceIfDifferent = [&Ret](QualType QT) {
if (QT.isNull())
return;
if (Ret.empty())
@@ -976,7 +976,7 @@ approximateStandardConversionSequence(const TheCheck &Check, QualType From,
// Get out the qualifiers of the original type. This will always be
// re-applied to the WorkType to ensure it is the same qualification as the
// original From was.
- auto FastQualifiersToApply = static_cast<unsigned>(
+ const auto FastQualifiersToApply = static_cast<unsigned>(
From.split().Quals.getAsOpaqueValue() & Qualifiers::FastMask);
// LValue->RValue is irrelevant for the check, because it is a thing to be
@@ -1595,7 +1595,7 @@ using ParamToSmallPtrSetMap =
template <typename MapTy, typename ElemTy>
static bool lazyMapOfSetsIntersectionExists(const MapTy &Map, const ElemTy &E1,
const ElemTy &E2) {
- auto E1Iterator = Map.find(E1);
+ const auto E1Iterator = Map.find(E1);
auto E2Iterator = Map.find(E2);
if (E1Iterator == Map.end() || E2Iterator == Map.end())
return false;
@@ -1637,7 +1637,7 @@ class AppearsInSameExpr : public RecursiveASTVisitor<AppearsInSameExpr> {
}
bool TraverseStmt(Stmt *S, DataRecursionQueue *Queue = nullptr) {
- if (auto *E = dyn_cast_or_null<Expr>(S)) {
+ if (const auto *E = dyn_cast_or_null<Expr>(S)) {
bool RootSetInCurrentStackFrame = false;
if (!CurrentExprOnlyTreeRoot) {
CurrentExprOnlyTreeRoot = E;
@@ -1678,7 +1678,7 @@ class PassedToSameFunction {
public:
void setup(const FunctionDecl *FD) {
- auto ParamsAsArgsInFnCalls =
+ const auto ParamsAsArgsInFnCalls =
match(functionDecl(forEachDescendant(
callExpr(forEachArgumentWithParam(
paramRefExpr(), parmVarDecl().bind("passed-to")))
@@ -1718,7 +1718,7 @@ class AccessedSameMemberOf {
public:
void setup(const FunctionDecl *FD) {
- auto MembersCalledOnParams = match(
+ const auto MembersCalledOnParams = match(
functionDecl(forEachDescendant(
memberExpr(hasObjectExpression(paramRefExpr())).bind("mem-expr"))),
*FD, FD->getASTContext());
@@ -1745,9 +1745,9 @@ class Returned {
public:
void setup(const FunctionDecl *FD) {
// TODO: Handle co_return.
- auto ParamReturns = match(functionDecl(forEachDescendant(
- returnStmt(hasReturnValue(paramRefExpr())))),
- *FD, FD->getASTContext());
+ const auto ParamReturns = match(functionDecl(forEachDescendant(returnStmt(
+ hasReturnValue(paramRefExpr())))),
+ *FD, FD->getASTContext());
for (const auto &Match : ParamReturns) {
const auto *ReturnedParam = Match.getNodeAs<ParmVarDecl>("param");
assert(ReturnedParam);
@@ -2001,7 +2001,7 @@ struct FormattedConversionSequence {
Trivial = false;
}
- auto AddType = [&](StringRef ToAdd) {
+ const auto AddType = [&](StringRef ToAdd) {
if (LastAddedType != ToAdd && ToAdd != SeqEndTypeStr) {
OS << " -> '" << ToAdd << "'";
LastAddedType = ToAdd.str();
@@ -2217,8 +2217,8 @@ void EasilySwappableParametersCheck::check(
DiagText = "%0 adjacent parameters of %1 of similar type ('%2') are "
"easily swapped by mistake";
- auto Diag = diag(First->getOuterLocStart(), DiagText)
- << static_cast<unsigned>(R.NumParamsChecked) << FD;
+ const auto Diag = diag(First->getOuterLocStart(), DiagText)
+ << static_cast<unsigned>(R.NumParamsChecked) << FD;
if (!NeedsAnyTypeNote)
Diag << FirstParamTypeAsWritten;
@@ -2281,7 +2281,7 @@ void EasilySwappableParametersCheck::check(
ExplicitlyPrintCommonType = true;
}
- auto Diag =
+ const auto Diag =
diag(LVar->getOuterLocStart(), DiagText, DiagnosticIDs::Note)
<< LTypeStr << RTypeStr;
if (ExplicitlyPrintCommonType)
@@ -2312,7 +2312,7 @@ void EasilySwappableParametersCheck::check(
DiagText = "'%0' and '%1' may be implicitly converted: %2, %3";
{
- auto Diag =
+ const auto Diag =
diag(RVar->getOuterLocStart(), DiagText, DiagnosticIDs::Note)
<< LTypeStr << RTypeStr;
diff --git a/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
index 9e5e1219b6387..bf721bac658b5 100644
--- a/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/EmptyCatchCheck.cpp
@@ -76,13 +76,13 @@ std::optional<TraversalKind> EmptyCatchCheck::getCheckTraversalKind() const {
}
void EmptyCatchCheck::registerMatchers(MatchFinder *Finder) {
- auto AllowedNamedExceptionDecl = namedDecl(
+ const auto AllowedNamedExceptionDecl = namedDecl(
matchers::matchesAnyListedRegexName(AllowEmptyCatchForExceptions));
auto AllowedNamedExceptionTypes =
qualType(anyOf(hasDeclaration(AllowedNamedExceptionDecl),
references(AllowedNamedExceptionDecl),
pointsTo(AllowedNamedExceptionDecl)));
- auto IgnoredExceptionType =
+ const auto IgnoredExceptionType =
qualType(anyOf(AllowedNamedExceptionTypes,
hasCanonicalType(AllowedNamedExceptionTypes)));
diff --git a/clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp
index 7d23e2d2b5630..ea2cbbc580d32 100644
--- a/clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/ExceptionEscapeCheck.cpp
@@ -106,7 +106,7 @@ void ExceptionEscapeCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
}
void ExceptionEscapeCheck::registerMatchers(MatchFinder *Finder) {
- auto MatchIf = [](bool Enabled, const auto &Matcher) {
+ const auto MatchIf = [](bool Enabled, const auto &Matcher) {
const ast_matchers::internal::Matcher<FunctionDecl> Nothing =
unless(anything());
return Enabled ? Matcher : Nothing;
diff --git a/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp
index 65578f7d81254..476bb25b77cac 100644
--- a/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp
@@ -143,7 +143,7 @@ void ForwardDeclarationNamespaceCheck::onEndOfTranslationUnit() {
}
// Check if a definition in another namespace exists.
const auto DeclName = CurDecl->getName();
- auto It = DeclNameToDefinitions.find(DeclName);
+ const auto It = DeclNameToDefinitions.find(DeclName);
if (It == DeclNameToDefinitions.end())
continue; // No definition in this translation unit, we can skip it.
// Make a warning for each definition with the same name (in other
diff --git a/clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp
index 8d4d9d67f17f4..9e2214a5c7c82 100644
--- a/clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/ForwardingReferenceOverloadCheck.cpp
@@ -17,7 +17,7 @@ namespace clang::tidy::bugprone {
namespace {
// Check if the given type is related to std::enable_if.
AST_MATCHER(QualType, isEnableIf) {
- auto CheckTemplate = [](const TemplateSpecializationType *Spec) {
+ const auto CheckTemplate = [](const TemplateSpecializationType *Spec) {
if (!Spec)
return false;
@@ -58,7 +58,7 @@ AST_MATCHER(TemplateDecl, hasAssociatedConstraints) {
} // namespace
void ForwardingReferenceOverloadCheck::registerMatchers(MatchFinder *Finder) {
- auto ForwardingRefParm =
+ const auto ForwardingRefParm =
parmVarDecl(
hasType(qualType(rValueReferenceType(),
references(templateTypeParmType(hasDeclaration(
diff --git a/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
index 7c259a6199832..126dc9ba36192 100644
--- a/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
+++ b/clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp
@@ -111,10 +111,10 @@ void ImplicitWideningOfMultiplicationResultCheck::handleImplicitCastExpr(
<< Ty << E->getType();
{
- auto Diag = diag(E->getBeginLoc(),
- "make conversion explicit to silence this warning",
- DiagnosticIDs::Note)
- << E->getSourceRange();
+ const auto Diag = diag(E->getBeginLoc(),
+ "make conversion explicit to silence this warning",
+ DiagnosticIDs::Note)
+ << E->getSourceRange();
const SourceLocation EndLoc = Lexer::getLocForEndOfToken(
E->getEndLoc(), 0, *Result->SourceManager, getLangOpts());
if (ShouldUseCXXStaticCast)
@@ -146,9 +146,10 @@ void ImplicitWideningOfMultiplicationResultCheck::handleImplicitCastExpr(
}
{
- auto Diag = diag(E->getBeginLoc(), "perform multiplication in a wider type",
- DiagnosticIDs::Note)
- << LHS->getSourceRange();
+ const auto Diag =
+ diag(E->getBeginLoc(), "perform multiplication in a wider type",
+ DiagnosticIDs::Note)
+ << LHS->getSourceRange();
if (ShouldUseCXXStaticCast)
Diag << FixItHint::CreateInsertion(LHS->getBeginLoc(),
@@ -225,10 +226,10 @@ void ImplicitWideningOfMultiplicationResultCheck::handlePointerOffsetting(
<< IndexExprType << TyAsString;
{
- auto Diag = diag(IndexExpr->getBeg...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/213841
More information about the cfe-commits
mailing list