[clang] dda7cb5 - [Driver][Hurd] Remove llvm_unreachable (#171077)

[via cfe-commits]

Author: Brad Smith
Date: 2026-08-03T08:17:05Z
New Revision: dda7cb5354cad9507bedbfd44d3fdc4c3e956d63

URL: https://github.com/llvm/llvm-project/commit/dda7cb5354cad9507bedbfd44d3fdc4c3e956d63
DIFF: https://github.com/llvm/llvm-project/commit/dda7cb5354cad9507bedbfd44d3fdc4c3e956d63.diff

LOG: [Driver][Hurd] Remove llvm_unreachable (#171077)

Remove the llvm_unreachable from getDynamicLinker(). The code path is
reachable. In the case of an unsupported architecture we're not worrying
about trying to actually determine the dynamic linker, and I don't think
it makes sense for the Driver to crash.

Pointed out by bug report #64194

---------

Co-authored-by: Shivam Gupta <shivam98.tkg at gmail.com>

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Hurd.cpp
    clang/lib/Driver/ToolChains/Managarm.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Hurd.cpp b/clang/lib/Driver/ToolChains/Hurd.cpp
index 53ee4d4c0cbde..b2c887fb72671 100644
--- a/clang/lib/Driver/ToolChains/Hurd.cpp
+++ b/clang/lib/Driver/ToolChains/Hurd.cpp
@@ -160,7 +160,7 @@ std::string Hurd::getDynamicLinker(const ArgList &Args) const {
     break;
   }
 
-  llvm_unreachable("unsupported architecture");
+  return "";
 }
 
 void Hurd::AddClangSystemIncludeArgs(const ArgList &DriverArgs,

diff  --git a/clang/lib/Driver/ToolChains/Managarm.cpp b/clang/lib/Driver/ToolChains/Managarm.cpp
index 4566e7258e929..5c35d27136416 100644
--- a/clang/lib/Driver/ToolChains/Managarm.cpp
+++ b/clang/lib/Driver/ToolChains/Managarm.cpp
@@ -127,8 +127,9 @@ std::string Managarm::getDynamicLinker(const ArgList &Args) const {
   case llvm::Triple::x86_64:
     return "/lib/x86_64-managarm/ld.so";
   default:
-    llvm_unreachable("unsupported architecture");
+    break;
   }
+  return "";
 }
 
 void Managarm::AddClangSystemIncludeArgs(const ArgList &DriverArgs,