[clang] [Clang] Skip type-aware operator delete resolution for incomplete pointee types (PR #213455)

via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 1 08:06:39 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/test/SemaCXX/type-aware-delete-incomplete-type.cpp clang/lib/Sema/SemaExprCXX.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp
index 089382919..e8e109d40 100644
--- a/clang/lib/Sema/SemaExprCXX.cpp
+++ b/clang/lib/Sema/SemaExprCXX.cpp
@@ -4155,9 +4155,9 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
                    : TypeAwareAllocationMode::No;
 
     if (PointeeRD) {
-      ImplicitDeallocationParameters IDP = {
-          Pointee, PassTypeIdentity,
-          AlignedAllocationMode::No, SizedDeallocationMode::No};
+      ImplicitDeallocationParameters IDP = {Pointee, PassTypeIdentity,
+                                            AlignedAllocationMode::No,
+                                            SizedDeallocationMode::No};
       if (!UseGlobal &&
           FindDeallocationFunction(StartLoc, PointeeRD, DeleteName,
                                    OperatorDelete, IDP))
@@ -4211,8 +4211,7 @@ Sema::ActOnCXXDelete(SourceLocation StartLoc, bool UseGlobal,
 
       // Look for a global declaration.
       ImplicitDeallocationParameters IDP = {
-          Pointee, PassTypeIdentity,
-          alignedAllocationModeFromBool(Overaligned),
+          Pointee, PassTypeIdentity, alignedAllocationModeFromBool(Overaligned),
           sizedDeallocationModeFromBool(CanProvideSize)};
       OperatorDelete = FindUsualDeallocationFunction(StartLoc, IDP, DeleteName);
       if (!OperatorDelete)

``````````

</details>


https://github.com/llvm/llvm-project/pull/213455


More information about the cfe-commits mailing list