[clang-tools-extra] [include-cleaner] Ensure receiver headers are kept when accessing ObjC properties (PR #212633)

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 1 07:06:32 PDT 2026


================
@@ -417,17 +417,32 @@ class ASTWalker : public RecursiveASTVisitor<ASTWalker> {
   }
 
   bool VisitObjCMessageExpr(ObjCMessageExpr *E) {
+    auto startLoc = E->getSelectorStartLoc();
     // Identify the selector and the method declaration
     if (auto *Method = E->getMethodDecl()) {
       // Report the method as a used symbol
-      report(E->getSelectorStartLoc(), Method);
+      report(startLoc, Method);
     }
 
     // If it's a class message, report the interface/class as used
     if (E->getReceiverKind() == ObjCMessageExpr::Class) {
       if (auto *Interface = E->getReceiverInterface()) {
         report(E->getReceiverRange().getBegin(), Interface);
       }
+    } else {
+      if (auto *Interface = E->getReceiverInterface()) {
+        report(startLoc, Interface, RefType::Implicit);
----------------
nico wrote:

nit: `report` already null-checks `Interface`, so you don't necessarily need to do it yourself. (Also in the previous if I suppose, but that predates you. Personally, I'd change it there too I think?)

https://github.com/llvm/llvm-project/pull/212633


More information about the cfe-commits mailing list