[clang-tools-extra] [clang-tidy] Fix trailing semicolon and lost comment in readability-use-std-min-max (PR #208782)

via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 1 00:48:06 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp clang-tools-extra/test/clang-tidy/checkers/readability/use-std-min-max.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp b/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp
index b1a4001e2..38e6dfb53 100644
--- a/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/UseStdMinMaxCheck.cpp
@@ -218,14 +218,12 @@ void UseStdMinMaxCheck::check(const MatchFinder::MatchResult &Result) {
       if (Semi != StringRef::npos && PostInner.take_front(Semi).trim().empty())
         PostInner = PostInner.drop_front(Semi + 1);
       AppendNormalized(PostInner);
-    } else {
-      if (const auto SemiTok =
-              Lexer::findNextToken(ThenLocation, Source, LO);
-          SemiTok && SemiTok->is(tok::semi)) {
-        AppendNormalized(
-            GetSourceText(ThenLocation, SemiTok->getLocation()).rtrim());
-        ThenLocation = SemiTok->getLocation();
-      }
+    } else if (const auto SemiTok =
+                   Lexer::findNextToken(ThenLocation, Source, LO);
+               SemiTok && SemiTok->is(tok::semi)) {
+      AppendNormalized(
+          GetSourceText(ThenLocation, SemiTok->getLocation()).rtrim());
+      ThenLocation = SemiTok->getLocation();
     }
 
     diag(IfLocation, "use `%0` instead of `%1`")

``````````

</details>


https://github.com/llvm/llvm-project/pull/208782


More information about the cfe-commits mailing list