https://github.com/erichkeane commented: 1 thing I'd love to see formatted differently, but otherwise I think this is alright? I can't say I've got enough knowledge of this to be sure however, so would like a second reviewer. https://github.com/llvm/llvm-project/pull/213191