[clang] [analyzer][NFC] Match the parameters order of getEndPath and finalizeVisitor with VisitNode (PR #212883)

Benedek Kaibas via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 30 04:06:52 PDT 2026


================
@@ -2438,8 +2443,7 @@ MallocChecker::FreeMemAux(CheckerContext &C, const Expr *ArgExpr,
       // Check if the memory location being freed is the actual location
       // allocated, or an offset.
       RegionOffset Offset = R->getAsOffset();
-      if (Offset.isValid() &&
-          !Offset.hasSymbolicOffset() &&
+      if (Offset.isValid() && !Offset.hasSymbolicOffset() &&
----------------
benedekaibas wrote:

Sorry, I did not check yesterday the files after opening the PR. It looks like my IDE setup for running `clang-format` when I save a file was doing it for the whole file instead of just the changed lines. I did force push the change in [2b7e695](https://github.com/llvm/llvm-project/commit/2b7e69544ab1e4a73cd06fd478e09c22f39455f1). 

I know force push should be avoided, but since this is the only review yet on this PR and it highlights the exact problem I was confident doing the force push. 

https://github.com/llvm/llvm-project/pull/212883


More information about the cfe-commits mailing list