[clang] [NFC][analyzer] Eliminate NodeBuilder from ExprEngine visit methods and from their utility methods (PR #212186)

DonĂ¡t Nagy via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 28 06:42:33 PDT 2026


================
@@ -837,9 +835,9 @@ void ExprEngine::VisitCXXDestructor(QualType ObjectType,
       Dest = MRMgr.getCXXTempObjectRegion(E, Pred->getStackFrame());
     } else {
       static SimpleProgramPointTag T("ExprEngine", "SkipInvalidDestructor");
-      NodeBuilder Bldr(Pred, Dst, *currBldrCtx);
-      Bldr.generateSink(Pred->getLocation().withTag(&T),
-                        Pred->getState(), Pred);
+      Dst.insert(Engine.makeNode(Pred->getLocation().withTag(&T),
+                                 Pred->getState(), Pred,
+                                 /* MarkAsSink */ true));
----------------
NagyDonat wrote:

```suggestion
      Engine.makeNode(Pred->getLocation().withTag(&T), Pred->getState(), Pred,
      		      /*MarkAsSink=*/true);

```

https://github.com/llvm/llvm-project/pull/212186


More information about the cfe-commits mailing list