[clang] [HIP] Use linker wrapper for device-only code object links (PR #211675)
Joseph Huber via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 28 04:37:24 PDT 2026
================
@@ -5154,15 +5163,40 @@ Driver::BuildOffloadingActions(Compilation &C, llvm::opt::DerivedArgList &Args,
(OffloadTriple->getOS() == llvm::Triple::OSType::AMDHSA ||
OffloadTriple->getOS() == llvm::Triple::OSType::ChipStar);
- if ((A->getType() != types::TY_Object && !IsHIPSPV &&
- A->getType() != types::TY_LTO_BC) ||
- HIPRelocatableObj || !HIPNoRDC || !offloadDeviceOnly())
+ if (HIPRelocatableObj || !HIPNoRDC || !offloadDeviceOnly()) {
----------------
jhuber6 wrote:
How important is this feature? I'm mostly wondering if this is something we'd need to be fast in the first place, or if there's some other way to simplify it. Intuitively I feel like most of this logic should be foldable into one of the existing paths but I'd need to study the code a bit more to say for sure.
https://github.com/llvm/llvm-project/pull/211675
More information about the cfe-commits
mailing list