[clang] [clang][CFG] Fix crash on statement-expression in condition variable (PR #212138)

[Oliver Hunt via cfe-commits]

https://github.com/ojhunt commented:

I would like some clarification of what was authored/changed by claude.

The comments match the style of Claude's excessive commentary, and the code changes themselves seem largely to be neutering assertions - an assertion failure is not a "crash", it is a sign of incorrect state, and this PR's description does not justify that the state is valid, simply that the state exists.

Maybe that is correct, but I don't see an actual justification for the statement expression behavior being correct, simply that it produces a state the assertions say is invalid.

https://github.com/llvm/llvm-project/pull/212138