[clang] [clang] Update diagnostics to include matrices as accepted types (PR #201237)

[Aaron Ballman via cfe-commits]

================
@@ -13323,7 +13323,8 @@ def err_builtin_is_within_lifetime_invalid_arg : Error<
 def err_builtin_invalid_arg_type: Error<
   "%ordinal0 argument must be a "
   // First component: scalar or container types
-  "%select{|scalar|vector|matrix|vector of|scalar or vector of}1"
+  "%select{|scalar|vector|matrix|vector of|scalar or vector of|"
----------------
AaronBallman wrote:

Drive-by comment: this should someday switch to using `%enum_select` (https://clang.llvm.org/docs/InternalsManual.html#formatting-a-diagnostic-argument) at some point but I can understand not switching to it as part of this PR given how incredibly complicated the select logic already is.

https://github.com/llvm/llvm-project/pull/201237