[clang] [llvm] [clang] Emit call graph type metadata for internal linkage symbols (PR #210194)

via cfe-commits cfe-commits at lists.llvm.org
Sat Jul 18 11:33:56 PDT 2026


Chengjunp wrote:

Hi, thanks for the change. While reviewing it in our downstream LLVM tree, we noticed a possible issue in the test updates. It seems the ending `E` was removed when changing `_ZTSFPvS_E.generalized` to `_ZTSFPvS_`. Could this be accidental, and should it be changed to `_ZTSFPvS_E` instead?

This appears in:

  - `llvm/test/CodeGen/ARM/call-graph-section-assembly.ll:36`
  - `llvm/test/CodeGen/ARM/call-graph-section.ll:30`
  - `llvm/test/CodeGen/X86/call-graph-section-assembly.ll:36`
  - `llvm/test/CodeGen/X86/call-graph-section.ll:33`

There is no test failure on our side—the tests pass. We just noticed this while reviewing and wanted to check whether it might be an issue.

https://github.com/llvm/llvm-project/pull/210194


More information about the cfe-commits mailing list