[clang] [llvm] [FMV][AIX] Implement target_clones part 2 (target-features) (PR #206786)

[via cfe-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 81595 tests passed
* 2158 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/PPC.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets/PPC.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\Targets\PPC.cpp.obj /Fdtools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Basic\Targets\PPC.cpp
In file included from C:\_work\llvm-project\llvm-project\clang\lib\Basic\Targets\PPC.cpp:13:
C:\_work\llvm-project\llvm-project\clang\lib\Basic\Targets\PPC.h(104,32): error: non-virtual member function marked 'override' hides virtual member function
104 |   bool setCPU(StringRef &Name) override {
|                                ^
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/TargetInfo.h(1404,16): note: hidden overloaded virtual function 'clang::TargetInfo::setCPU' declared here: type mismatch at 1st parameter ('StringRef' vs 'StringRef &')
1404 |   virtual bool setCPU(StringRef Name) { return false; }
|                ^
1 error generated.
```
</details>
<details>
<summary>[code=1] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Targets.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\lib\Basic -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\Targets.cpp.obj /Fdtools\clang\lib\Basic\CMakeFiles\obj.clangBasic.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Basic\Targets.cpp
In file included from C:\_work\llvm-project\llvm-project\clang\lib\Basic\Targets.cpp:32:
C:\_work\llvm-project\llvm-project\clang\lib\Basic\Targets/PPC.h(104,32): error: non-virtual member function marked 'override' hides virtual member function
104 |   bool setCPU(StringRef &Name) override {
|                                ^
C:\_work\llvm-project\llvm-project\clang\include\clang/Basic/TargetInfo.h(1404,16): note: hidden overloaded virtual function 'clang::TargetInfo::setCPU' declared here: type mismatch at 1st parameter ('StringRef' vs 'StringRef &')
1404 |   virtual bool setCPU(StringRef Name) { return false; }
|                ^
1 error generated.
```
</details>
<details>
<summary>[code=1] tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaPPC.cpp.obj</summary>

```
FAILED: [code=1] tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaPPC.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DCLANG_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\clang\lib\Sema -IC:\_work\llvm-project\llvm-project\clang\lib\Sema -IC:\_work\llvm-project\llvm-project\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\clang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\clang\lib\Sema\CMakeFiles\obj.clangSema.dir\SemaPPC.cpp.obj /Fdtools\clang\lib\Sema\CMakeFiles\obj.clangSema.dir\ -c -- C:\_work\llvm-project\llvm-project\clang\lib\Sema\SemaPPC.cpp
C:\_work\llvm-project\llvm-project\clang\lib\Sema\SemaPPC.cpp(656,16): error: use of undeclared identifier 'isValidFeatureName'; did you mean 'llvm::PPC::isValidFeatureName'?
656 |         assert(isValidFeatureName(FeatureName));
|                ^~~~~~~~~~~~~~~~~~
|                llvm::PPC::isValidFeatureName
C:\Program Files (x86)\Windows Kits\10\include\10.0.26100.0\ucrt\assert.h(40,17): note: expanded from macro 'assert'
40 |             (!!(expression)) ||                                                               \
|                 ^~~~~~~~~~
C:\_work\llvm-project\llvm-project\llvm\include\llvm/TargetParser/PPCTargetParser.h(46,15): note: 'llvm::PPC::isValidFeatureName' declared here
46 | LLVM_ABI bool isValidFeatureName(StringRef Name);
|               ^
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/206786