[clang] [Clang] Restrict CWG1504 devirtualization to pointer arithmetic on record types. (PR #209593)

[Aaron Ballman via cfe-commits]

AaronBallman wrote:

> To be clear, reverting is routine; it keeps downstream builds green, and simplifies the work of the release managers on the branch. It's not supposed to be a reflection on the quality of your work, and I expect we can reland soon.

Thank you for explicitly mentioning this @efriedma-quic, I should have made that more clear as well (mea culpa!).

It's part of our developer policy to bias toward reverting: https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy It's absolutely not a reflection on the PR author (my own work gets reverted for similar kinds of scenarios, it happens to all of us at some point).

https://github.com/llvm/llvm-project/pull/209593