[clang] [clang][ExprConst] Support virtual bases in C++26 (PR #204289)

[Yihan Wang via cfe-commits]

================
@@ -49,12 +49,20 @@ bool Record::hasTrivialDtor() const {
   return !Dtor || Dtor->isTrivial();
 }
 
-const Record::Base *Record::getBase(const RecordDecl *FD) const {
-  auto It = BaseMap.find(FD);
+const Record::Base *Record::getBase(const RecordDecl *RD) const {
+  auto It = BaseMap.find(RD);
   assert(It != BaseMap.end() && "Missing base");
   return It->second;
 }
 
+const Record::Base *Record::getBaseOrNull(const RecordDecl *RD) const {
+  return BaseMap.lookup(RD);
----------------
yronglin wrote:

This looks incorrect to me, the code following return statement is dead code.

https://github.com/llvm/llvm-project/pull/204289