[clang] [Lifetime Safety] Highlight lifetimebound calls in alias chain diagnostics (PR #206337)

[Gábor Horváth via cfe-commits]

================
@@ -664,20 +664,66 @@ class LifetimeSafetySemaHelperImpl : public LifetimeSafetySemaHelper {
     return CurrExpr->getSourceRange() != LastExpr->getSourceRange();
   }
 
+  bool shouldCarryHiddenLifetimeBound(const Expr *HiddenExpr,
----------------
Xazax-hun wrote:

I think this PR is getting too big. We do not need the first version to be perfect and handle all cases. If some of the messages do not show up due to some source ranges being the same that is fine. I'd prefer to keep this PR as small and targeted as possible and defer the further improvements to a follow-up PR. Otherwise we will be stuck in an eternal review loop. 

https://github.com/llvm/llvm-project/pull/206337