[clang] 7206149 - [NFC][clang] Adjust PPMemoryAllocationsTest threshold for ASan (#209024)
via cfe-commits
cfe-commits at lists.llvm.org
Sun Jul 12 08:19:16 PDT 2026
Author: Vitaly Buka
Date: 2026-07-12T15:19:11Z
New Revision: 7206149c21b420a3aa5a0c9a78f1a1ad6ff8ed89
URL: https://github.com/llvm/llvm-project/commit/7206149c21b420a3aa5a0c9a78f1a1ad6ff8ed89
DIFF: https://github.com/llvm/llvm-project/commit/7206149c21b420a3aa5a0c9a78f1a1ad6ff8ed89.diff
LOG: [NFC][clang] Adjust PPMemoryAllocationsTest threshold for ASan (#209024)
PPMemoryAllocationsTest.PPMacroDefinesAllocations measures the memory
footprint of the preprocessor allocator and asserts a strict threshold
of 130.0 bytes per define.
When built with ASan, the allocator adds redzones to allocations,
which increases the total memory reported by `getTotalMemory()` and
causes the test to fail (reporting ~136.8 bytes per define).
Adjust the threshold to 145.0 bytes per define when built with ASan
(detected via `LLVM_ADDRESS_SANITIZER_BUILD`) to account for this
overhead while maintaining the strict limit for standard builds.
Assisted-by: Gemini
Added:
Modified:
clang/unittests/Lex/PPMemoryAllocationsTest.cpp
Removed:
################################################################################
diff --git a/clang/unittests/Lex/PPMemoryAllocationsTest.cpp b/clang/unittests/Lex/PPMemoryAllocationsTest.cpp
index ebdb0346b3bed..06308a5b5e6b7 100644
--- a/clang/unittests/Lex/PPMemoryAllocationsTest.cpp
+++ b/clang/unittests/Lex/PPMemoryAllocationsTest.cpp
@@ -18,6 +18,7 @@
#include "clang/Lex/ModuleLoader.h"
#include "clang/Lex/Preprocessor.h"
#include "clang/Lex/PreprocessorOptions.h"
+#include "llvm/Support/Compiler.h"
#include "gtest/gtest.h"
using namespace clang;
@@ -89,7 +90,11 @@ TEST_F(PPMemoryAllocationsTest, PPMacroDefinesAllocations) {
// Assume a reasonable upper bound based on that number that we don't want
// to exceed when storing information about a macro #define with 1 or 3
// tokens.
+#if LLVM_ADDRESS_SANITIZER_BUILD
+ EXPECT_LT(BytesPerDefine, 145.0f);
+#else
EXPECT_LT(BytesPerDefine, 130.0f);
+#endif
}
} // anonymous namespace
More information about the cfe-commits
mailing list