[clang] [CIR][AMDGPU] Add support for AMDGCN fcmp builtins (PR #198135)

via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 10 17:19:31 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h clang/lib/CIR/CodeGen/CIRGenBuiltinAMDGPU.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h b/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
index 92ed11913..b8d03bbb5 100644
--- a/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
+++ b/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h
@@ -614,8 +614,9 @@ public:
     return CreateFCmpHelper(P, LHS, RHS, Name, FPMathTag, {}, false);
   }
 
-  mlir::Value createCmp(CmpInst::Predicate Pred, mlir::Value lhs, mlir::Value rhs,
-                   const Twine &name = "", MDNode *FPMathTag = nullptr) {
+  mlir::Value createCmp(CmpInst::Predicate Pred, mlir::Value lhs,
+                        mlir::Value rhs, const Twine &name = "",
+                        MDNode *FPMathTag = nullptr) {
     return CmpInst::isFPPredicate(Pred)
                ? CreateFCmp(Pred, LHS, RHS, Name, FPMathTag)
                : CreateICmp(Pred, LHS, RHS, Name);
@@ -624,8 +625,8 @@ public:
 private:
   // Helper routine to create either a signaling or a quiet FP comparison.
   mlir::Value *CreateFCmpHelper(CmpInst::Predicate P, Value *LHS, Value *RHS,
-                                   const Twine &Name, MDNode *FPMathTag,
-                                   FMFSource FMFSource, bool IsSignaling);
+                                const Twine &Name, MDNode *FPMathTag,
+                                FMFSource FMFSource, bool IsSignaling);
 
   //===--------------------------------------------------------------------===//
   // Other Instructions

``````````

</details>


https://github.com/llvm/llvm-project/pull/198135


More information about the cfe-commits mailing list