[clang-tools-extra] [clang-doc] Remove stale FIXME (PR #208795)
Paul Kirth via cfe-commits
cfe-commits at lists.llvm.org
Fri Jul 10 10:48:22 PDT 2026
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/208795
This was fixed a long time ago when relanding arena support. This FIXME was missed when we folded in the deep copying to the reland. It can safely be removed, as the situation it warns about cannot happen anymore.
>From c8d6f82b6c437dc721edfae04ec0128a34a04c43 Mon Sep 17 00:00:00 2001
From: Paul Kirth <paulkirth at google.com>
Date: Fri, 10 Jul 2026 17:45:01 +0000
Subject: [PATCH] [clang-doc] Remove stale FIXME
This was fixed a long time ago when relanding area support. This fixme
was missed when we folded in the deep copying to the reland. It can
safely be removed, as the situation it warns about cannot happen
anymore.
---
clang-tools-extra/clang-doc/Representation.cpp | 5 -----
1 file changed, 5 deletions(-)
diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp
index 414b5a2377bcf..e71b3ddad78a8 100644
--- a/clang-tools-extra/clang-doc/Representation.cpp
+++ b/clang-tools-extra/clang-doc/Representation.cpp
@@ -485,11 +485,6 @@ void NamespaceInfo::merge(NamespaceInfo &&Other) {
RecordInfo::RecordInfo(SymbolID USR, StringRef Name, StringRef Path)
: SymbolInfo(InfoType::IT_record, USR, Name, Path) {}
-// FIXME: This constructor is currently unsafe for cross-arena copies of
-// populated records. Because a default copy of ScopeChildren will shallow-copy
-// the intrusive pointers, leading to a use-after-free when the TransientArena
-// is reset. Subsequent patches will address this by deep-copying children
-// individually via reduceChildren.
RecordInfo::RecordInfo(const RecordInfo &Other, llvm::BumpPtrAllocator &Arena)
: SymbolInfo(Other, Arena), TagType(Other.TagType),
IsTypeDef(Other.IsTypeDef) {
More information about the cfe-commits
mailing list