[clang] [clang][ARM64X] Support compiling both native and EC objects with -marm64x (PR #207612)

Martin Storsjö via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 6 03:34:44 PDT 2026


================
@@ -801,9 +801,11 @@ Tool *ToolChain::getTool(Action::ActionClass AC) const {
   case Action::VerifyDebugInfoJobClass:
   case Action::BinaryAnalyzeJobClass:
   case Action::BinaryTranslatorJobClass:
-  case Action::ObjcopyJobClass:
     llvm_unreachable("Invalid tool kind.");
 
+  case Action::ObjcopyJobClass:
+    return nullptr;
----------------
mstorsjo wrote:

Why is this change needed here? Isn't this overridden for the specific target toolchains that implement it? Doesn't this make it a silent no-op rather than hitting an `llvm_unreachable` if another toolchain would get here?

https://github.com/llvm/llvm-project/pull/207612


More information about the cfe-commits mailing list