[clang] [clang] Prevent nested RecoveryExpr in BuildConvertedConstantExpression (PR #207072)

[Matheus Izvekov via cfe-commits]

================
@@ -6499,6 +6499,8 @@ static ExprResult BuildConvertedConstantExpression(Sema &S, Expr *From,
     return ExprError();
 
   if (From->containsErrors()) {
+    if (isa<RecoveryExpr>(From))
----------------
mizvekov wrote:

What if the existing RecoveryExpr has a type which is not T?
Wasn't that the point of the PR which introduced this check?

What about not introducing the RecoveryExpr in case the expression already has type T?

https://github.com/llvm/llvm-project/pull/207072