[clang] [clang-format] Fix crash on numeric literals with an incomplete exponent (PR #206594)

via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 30 22:02:53 PDT 2026


Gustas =?utf-8?q?Janušonis?= <janusonis.gustas at gmail.com>,
Gustas =?utf-8?q?Janušonis?= <janusonis.gustas at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/206594 at github.com>


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Format/NumericLiteralInfo.cpp clang/unittests/Format/NumericLiteralCaseTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/lib/Format/NumericLiteralInfo.cpp b/clang/lib/Format/NumericLiteralInfo.cpp
index 5738193c7..b4d0873cd 100644
--- a/clang/lib/Format/NumericLiteralInfo.cpp
+++ b/clang/lib/Format/NumericLiteralInfo.cpp
@@ -61,7 +61,8 @@ NumericLiteralInfo::NumericLiteralInfo(StringRef Text, char Separator) {
         return (HasExponent || !IsHex ? isDigit : isHexDigit)(C) ||
                C == Separator;
       },
-      std::min(HasExponent ? ExponentLetterPos + 2 : Pos, Text.size())); // e.g. 1e-2f
+      std::min(HasExponent ? ExponentLetterPos + 2 : Pos,
+               Text.size())); // e.g. 1e-2f
 }
 
 } // namespace format

``````````

</details>


https://github.com/llvm/llvm-project/pull/206594


More information about the cfe-commits mailing list