[clang] [lld] [lld][COFF] Add optimization remarks options to lld-link (PR #205390)

via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 29 18:55:52 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/lib/Driver/ToolChains/MSVC.cpp lld/COFF/Config.h lld/COFF/Driver.cpp lld/COFF/LTO.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lld/COFF/Driver.cpp b/lld/COFF/Driver.cpp
index 4c19b8daf..da5ee7f5c 100644
--- a/lld/COFF/Driver.cpp
+++ b/lld/COFF/Driver.cpp
@@ -2299,14 +2299,12 @@ void LinkerDriver::linkerMain(ArrayRef<const char *> argsArr) {
   config->optRemarksFilename = args.getLastArgValue(OPT_opt_remarks_filename);
   config->optRemarksPasses = args.getLastArgValue(OPT_opt_remarks_passes);
   config->optRemarksFormat = args.getLastArgValue(OPT_opt_remarks_format);
-  config->optRemarksWithHotness =
-      args.hasArg(OPT_opt_remarks_with_hotness);
+  config->optRemarksWithHotness = args.hasArg(OPT_opt_remarks_with_hotness);
   if (auto *arg = args.getLastArg(OPT_opt_remarks_hotness_threshold)) {
     auto resultOrErr = remarks::parseHotnessThresholdOption(arg->getValue());
     if (!resultOrErr)
       Err(ctx) << arg->getSpelling() << ": invalid argument '"
-               << arg->getValue()
-               << "', only integer or 'auto' is supported";
+               << arg->getValue() << "', only integer or 'auto' is supported";
     else
       config->optRemarksHotnessThreshold = *resultOrErr;
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/205390


More information about the cfe-commits mailing list